Wireshark-commits: [Wireshark-commits] lts-1.12.1 cde7826: replace dangerous tvb_get_ptr with safer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 19:43:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cde78261a2d26f8b3e11295b9eaeed2fb840ea0c
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

cde7826 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    replace dangerous tvb_get_ptr with safer string function.
    
    Using tvb_get_ptr to get a string is always dangerous in the face of
    malformed packets. Instead using string functions allow for safe handling
    of these.
    
    Bug: 12242
    Change-Id: Id5a57a3d9ab744386b3358d378fe9e0e62df54fa
    Reviewed-on: https://code.wireshark.org/review/14769
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit df3d07b4bf80decf504cb007b9a73c85a3eef737)
    Reviewed-on: https://code.wireshark.org/review/15443
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  f594622   Restrict the depth of the protocol tree.
    adds  cde7826   replace dangerous tvb_get_ptr with safer string function.


Summary of changes:
 epan/dissectors/packet-pktc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)