Wireshark-commits: [Wireshark-commits] lts-1.12.1 f594622: Restrict the depth of the protocol tree.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 19:42:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5946221504c14ea056818ffd609f7aa5156da4f
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

f594622 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Restrict the depth of the protocol tree.
    
    Limit the the protocol tree to 500 levels. This keeps us from running
    out of stack space in proto_tree_traverse_{pre,post}_order.
    
    Bug: 12268
    Change-Id: I60f6b4487bf51a4d43da0429819a8a20fbdb313a
    Reviewed-on: https://code.wireshark.org/review/14887
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 8dc9551e1d56290e6f7f02cc38b77e1d211fd4a5)
    Reviewed-on: https://code.wireshark.org/review/15010
    (cherry picked from commit c5a9678f5f601a86745e5108323a573171d23fac)
    Reviewed-on: https://code.wireshark.org/review/15442
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  1c9d2c8   [RSL] Just return rest of packet if TLV type is unknown
    adds  f594622   Restrict the depth of the protocol tree.


Summary of changes:
 epan/proto.c |   25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)