Wireshark-commits: [Wireshark-commits] master-1.12 16254fd: GSM A RR: fix dissection of GPRS Cell O
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 May 2016 09:56:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16254fd95a5e62d8c13255d666708723334ddcae
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

16254fd by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    GSM A RR: fix dissection of GPRS Cell Options IE
    
    As seen in the capture given in https://www.wireshark.org/lists/wireshark-users/201605/msg00007.html
    The extension length is not always equal to ll the options defined for a given release
    
    Change-Id: I68ba57dd384122eed1f1ff36cc8acc7ef029fcd0
    Reviewed-on: https://code.wireshark.org/review/15290
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit b9368fcdb8226ff55365e85a71b0a581faf8c6c6)
    Conflicts:
    	epan/dissectors/packet-gsm_a_rr.c
    Reviewed-on: https://code.wireshark.org/review/15303
    

Actions performed:

    from  d879d87   LAPSat: fix reported length for tvb subset
    adds  16254fd   GSM A RR: fix dissection of GPRS Cell Options IE


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c |   95 ++++++++++++++++++++-----------------
 1 file changed, 51 insertions(+), 44 deletions(-)