Wireshark-commits: [Wireshark-commits] master ae4a912: TShark: Convert TTY output.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 May 2016 04:11:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae4a912af04456a6fc4022150485be541f65d96c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae4a912 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    TShark: Convert TTY output.
    
    If we detect that we're writing to a TTY and that it doesn't support
    UTF-8, convert our output to the current code page on UNIX/Linux or
    to UTF-16LE on Windows. This helps to ensure that we don't fill users'
    screens with mojibake, along with scrubbing invalid output.
    
    Add a note about our output behavior to the TShark man page. Add a note
    about the glyphs we should and shouldn't be using to utf8_entities.h.
    
    Bug: 12393
    
    Change-Id: I52b6dd240173b80ffb6d35b5950a46a565c97ce8
    Reviewed-on: https://code.wireshark.org/review/15277
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6bd2e29   SMI_DLL should not be part of directory path for copying MIBs
    adds  ae4a912   TShark: Convert TTY output.


Summary of changes:
 doc/tshark.pod         |   14 ++++++++++++++
 epan/print_stream.c    |   49 +++++++++++++++++++++++++++++++++++++++++++++++-
 wsutil/utf8_entities.h |    7 +++++++
 3 files changed, 69 insertions(+), 1 deletion(-)