Wireshark-commits: [Wireshark-commits] master 4de738f: Fix byte pane not showing up in Packet dialo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Mar 2016 07:29:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4de738f5a720012afde1c9e38b1cbf1131fdee34
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4de738f by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix byte pane not showing up in Packet dialog
    
    When a packet dialog is being constructed, the layout is apparently not
    fixed yet and the byte view is technically not visible. Fix the hidden
    byte pane by not hiding it when it is not (yet) visible.
    
    Bug: 11760
    Change-Id: I0494fa16a5ed89ff31f934ba682a6bb884cc0e2e
    Reviewed-on: https://code.wireshark.org/review/14713
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  ad09738   replace dangerous tvb_get_ptr with safer string function.
    adds  4de738f   Fix byte pane not showing up in Packet dialog


Summary of changes:
 ui/qt/byte_view_tab.cpp |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)