Wireshark · Wireshark-commits: [Wireshark-commits] master ad09738: replace dangerous tvb_get_ptr with safer string function.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad097385c05c370440fb810e67f811398efc0ea0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ad09738 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    replace dangerous tvb_get_ptr with safer string function.
    
    Using tvb_get_ptr to get a string is always dangerous in the face of
    malformed packets. Instead using string functions allow for safe handling
    of these.
    
    Bug: 12242
    Change-Id: I059c186032492aae9c90a69858ea3fc59e21313f
    Reviewed-on: https://code.wireshark.org/review/14714
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6ef16a8   Add a NULL check: it's not sure we have a radius_call here.
    adds  ad09738   replace dangerous tvb_get_ptr with safer string function.


Summary of changes:
 epan/dissectors/packet-pktc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)