Wireshark-commits: [Wireshark-commits] lts-1.8.2 1472ec2: ber: fix buffer overrun when handling emp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Mar 2016 20:18:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1472ec2a3857266faaf2b4fe59457bd4ca28ae50
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

1472ec2 by Peter Wu (peter@xxxxxxxxxxxxx):

    ber: fix buffer overrun when handling empty sets
    
    When a set is empty, only a terminator (ber_sequence_t with NULL func)
    is present. In that case, do not try to find more values as that will
    never succeed.
    
    Bug: 12106
    Change-Id: I26cd4ba84a9580e92d5921592a27c2af17c0bebf
    Reviewed-on: https://code.wireshark.org/review/14028
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 55b5b7caf3ec4856838b0416d5a91d3a3ff67ec8)
    Reviewed-on: https://code.wireshark.org/review/14036
    (cherry picked from commit c43f94f03a46cd5778e807aa3454dbbb48dfaed9)
    Reviewed-on: https://code.wireshark.org/review/14347
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    (cherry picked from commit f03f508842a1fba434a6990bf8e5773aa4763abd)
    Reviewed-on: https://code.wireshark.org/review/14374
    

Actions performed:

    from  08fcb4a   gsm_abis_oml: fix buffer overrun
    adds  1472ec2   ber: fix buffer overrun when handling empty sets


Summary of changes:
 epan/dissectors/packet-ber.c |    4 ++++
 1 file changed, 4 insertions(+)