Wireshark-commits: [Wireshark-commits] lts-1.8.2 08fcb4a: gsm_abis_oml: fix buffer overrun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Mar 2016 20:17:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08fcb4a986a7fe32b15024586545b9bef0472997
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

08fcb4a by Peter Wu (peter@xxxxxxxxxxxxx):

    gsm_abis_oml: fix buffer overrun
    
    Do not read outside boundaries when tag is exactly 0xff.
    
        tag = tvb_get_guint8(tvb, offset);
        tdef = find_tlv_tag(tag);
            ...
            return &nm_att_tlvdef_base.def[tag];
    
    Bug: 11825
    Change-Id: I42e624185abb2166aa0f8d0dbd71a2a86fc0b18e
    Reviewed-on: https://code.wireshark.org/review/14030
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit c31425f9ae15067e26ccc6183c206c34713cb256)
    Reviewed-on: https://code.wireshark.org/review/14344
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    (cherry picked from commit d223fd6de0520a051a9f8b50fc975fe96e9ba4b2)
    Reviewed-on: https://code.wireshark.org/review/14373
    

Actions performed:

    from  1f0d969   rsl: avoid buffer overread
    adds  08fcb4a   gsm_abis_oml: fix buffer overrun


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)