Wireshark-commits: [Wireshark-commits] master f2de3c7: Improve wiretap block capabilities.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Mar 2016 12:53:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2de3c7778c8712ddeef877055db4cba82a9b40a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f2de3c7 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Improve wiretap block capabilities.
    
    Make a more formal method for registering options within a block and do it all with a single function (wtap_optionblock_add_block).
    Add ability for block to be able to write itself, refactored out of pcapng.c.  This was implemented for SHB, ISB, and IDB blocks.  Name resolution (NRB), while possible, seemed a little messy for the moment.
    
    Change-Id: Ie855c8550c7c7d96cfc188c0cd90bfbc4d5f0ee8
    Reviewed-on: https://code.wireshark.org/review/14357
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  32d60ac   CMake: Avoid pipes and the `cut` command.
    adds  f2de3c7   Improve wiretap block capabilities.


Summary of changes:
 wiretap/pcapng.c        |  815 +----------------------------------------------
 wiretap/pcapng.h        |   44 +++
 wiretap/wtap_opttypes.c |  781 +++++++++++++++++++++++++++++++++++----------
 wiretap/wtap_opttypes.h |  149 ++++-----
 4 files changed, 725 insertions(+), 1064 deletions(-)