Wireshark-commits: [Wireshark-commits] master 32d60ac: CMake: Avoid pipes and the `cut` command.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32d60ac2f55f38f2d29a57fea8be008432846367
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
32d60ac by Gerald Combs (gerald@xxxxxxxxxxxxx):
CMake: Avoid pipes and the `cut` command.
Dump the output of `git shortlog` directly to AUTHORS.git instead of
piping it through `cut`. Depending on our toolchain, cmake COMMANDs might
not support pipes. This appears to be the case for MSBuild. Removing the
`cut` command has the added benefit of reducing our dependency on Cygwin.
Pass HEAD to `git shortlog`, otherwise it doesn't return anything when
run under MSBuild.
Change-Id: I23e9436c007d76a700bbbc45c2772c8aba6d5749
Reviewed-on: https://code.wireshark.org/review/14349
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from e86dd03 usb: display correctly index/interface/endpoint in urb setup
adds 32d60ac CMake: Avoid pipes and the `cut` command.
Summary of changes:
CMakeLists.txt | 15 +++++++++------
tools/generate_authors.pl | 4 +++-
2 files changed, 12 insertions(+), 7 deletions(-)