Wireshark-commits: [Wireshark-commits] master b9fb2ce: Add heuristic dissectors for the variable pa
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9fb2ceb88b0904e95b2931fbf2efd6222f56285
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b9fb2ce by Guy Harris (guy@xxxxxxxxxxxx):
Add heuristic dissectors for the variable part of COTP CR and CC PDUs.
Add tables for heuristic dissectors, and add dissectors for the stuff
Microsoft puts there for RDP; they're violating the COTP spec, but I
guess they're stuck because they're using TP0, which doesn't support
user data.
While we're at it, add variants of proto_tree_add_bitmask() and
proto_tree_add_bitmask_flags() that return the bitmask, for use by
callers.
A side-effect of the change is that the proto_tree_add_bitmask routines
no longer treat the encoding as a Boolean, so we have to pass
ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN, not just some non-zero or zero
value. Do so.
Rename ositp_decode_CC() to ositp_decode_CR_CC(), to note that it
decodes both CR and CC PDUs.
Bug: 2626
Change-Id: If5fa2a6dfecd9eb99c1cb8104f2ebceccf1e57c2
Reviewed-on: https://code.wireshark.org/review/13648
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from a53ab9d Fix leaks when spawning extcap processes
adds b9fb2ce Add heuristic dissectors for the variable part of COTP CR and CC PDUs.
Summary of changes:
epan/dissectors/packet-dcerpc-netlogon.c | 15 +-
epan/dissectors/packet-ositp.c | 77 +++---
epan/dissectors/packet-rdp.c | 378 +++++++++++++++++++++++++++++-
epan/proto.c | 225 +++++++++---------
epan/proto.h | 88 ++++++-
5 files changed, 616 insertions(+), 167 deletions(-)
