Wireshark-commits: [Wireshark-commits] master-2.0 a095628: Qt: Fixup the Display Filter Expression
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Feb 2016 23:01:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a095628e499e1ac3a5f06336f2f2d072c8a0c36c
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a095628 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fixup the Display Filter Expression syntax logic.
    
    In the Display Filter Expression dialog, only disable the OK button when
    we have an invalid filter.
    
    Move the deprecated warning string from DisplayFilterEdit::checkFilter
    to SyntaxLineEdit::checkDisplayFilter so that we can use it in more
    places.
    
    Change-Id: I938f5f10258f4fd9dd3a33c174dd9958c9634766
    Reviewed-on: https://code.wireshark.org/review/13317
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 6d0bc20d4e4853deb7da13312fb3eb3e36b4160f)
    Reviewed-on: https://code.wireshark.org/review/13397
    

Actions performed:

    from  00a1890   PIM: fix IPv4/IPv6 filters using the same name for different address type
    adds  a095628   Qt: Fixup the Display Filter Expression syntax logic.


Summary of changes:
 ui/qt/display_filter_edit.cpp              |    8 +-------
 ui/qt/display_filter_expression_dialog.cpp |    2 +-
 ui/qt/syntax_line_edit.cpp                 |   13 ++++++-------
 ui/qt/syntax_line_edit.h                   |    1 -
 4 files changed, 8 insertions(+), 16 deletions(-)