Wireshark-commits: [Wireshark-commits] master-2.0 adbee00: Qt: Add missing multi-field column valid
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Dec 2015 23:17:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=adbee00d92209bf32ad1d1c79bb0e6de305aa86a
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

adbee00 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Add missing multi-field column validation
    
    GTK already has it, but Qt forgot about it, so multi-field custom column
    works ok if previously saved in GTK-shark. Invalid validation prevent from
    modifying and saving multi-field custom column in Qt version.
    
    This is a manual merge from 9bb3f6be without the field -> fields change.
    
    Change-Id: I4f9ddecd468cf5521d3ed6b4d64f98c3b094c9e4
    Reviewed-on: https://code.wireshark.org/review/12893
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  efc9ecf   Qt: fix QString::arg: Argument missing: "PT=%u telephone/event" warning
    adds  adbee00   Qt: Add missing multi-field column validation


Summary of changes:
 ui/qt/column_editor_frame.cpp      |    4 ++--
 ui/qt/column_preferences_frame.cpp |    2 +-
 ui/qt/syntax_line_edit.cpp         |   25 +++++++++++++++++++++++++
 ui/qt/syntax_line_edit.h           |    1 +
 4 files changed, 29 insertions(+), 3 deletions(-)