Wireshark-commits: [Wireshark-commits] master 0d29476: Save the results of wmem_strndup(NULL, ...)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Dec 2015 23:01:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d2947681c80e5e329b5ad234a672bee36e68163
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0d29476 by Guy Harris (guy@xxxxxxxxxxxx):

    Save the results of wmem_strndup(NULL, ...) in a non-const pointer.
    
    That way, we have a non-const pointer to use when freeing it, and don't
    have to undo the constification with a cast.
    
    Rename "has_slash" to "slash", while we're at it, as it's not a Boolean
    indicating whether the string has a slash, it's either a pointer to the
    slash in question or NULL if the string has no slash.
    
    Change-Id: Ia55b39bddb67c8ca71f7b09ee5eb82efaa3bdf0c
    Reviewed-on: https://code.wireshark.org/review/12891
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bc13e83   Don't cast away constness for the key in g_hash_table_lookup().
    adds  0d29476   Save the results of wmem_strndup(NULL, ...) in a non-const pointer.


Summary of changes:
 epan/ftypes/ftype-ipv4.c |   28 ++++++++++++++--------------
 epan/ftypes/ftype-ipv6.c |   29 ++++++++++++++++-------------
 2 files changed, 30 insertions(+), 27 deletions(-)