Wireshark-commits: [Wireshark-commits] master-2.0 ada125e: ui: Optimize col_custom_prime_edt()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Dec 2015 21:37:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ada125e02669d2bc9a6d0a678a6d3f12e5b0b12d
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ada125e by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    ui: Optimize col_custom_prime_edt()
    
    The col_item->col_custom_fields_ids list does not change between
    packet so this can be initialized in build_column_format_array().
    
    Change-Id: I171b583912dbd1568c3d85159fac1ab435dcaa7c
    Reviewed-on: https://code.wireshark.org/review/12801
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/12829
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  ec166e2   Qt: Plug memory leak in ByteViewText.
    adds  ada125e   ui: Optimize col_custom_prime_edt()


Summary of changes:
 epan/column-utils.c |   30 ------------------------------
 epan/column.c       |   17 +++++++++++++++++
 2 files changed, 17 insertions(+), 30 deletions(-)