Wireshark-commits: [Wireshark-commits] master-2.0 ec166e2: Qt: Plug memory leak in ByteViewText.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Dec 2015 20:43:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec166e20b5165d0f1765f14e2d55d22dbc23425e
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ec166e2 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Plug memory leak in ByteViewText.
    
    Each time we create a ByteViewText, which is twice when a packet is
    selected, the menu items leaks.  Ensure we clear the items when done.
    
    Change-Id: Idf0c7b82bf241120dd4c42ba85c56c0a2bf8db46
    Reviewed-on: https://code.wireshark.org/review/12826
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 299717879554ee2fc7d06fedded6207cfdcd1f22)
    Reviewed-on: https://code.wireshark.org/review/12830
    

Actions performed:

    from  3a28602   DNS: fix malformed warning when there is no quest(ions)
    adds  ec166e2   Qt: Plug memory leak in ByteViewText.


Summary of changes:
 ui/qt/byte_view_text.cpp |    5 +++++
 ui/qt/byte_view_text.h   |    2 ++
 2 files changed, 7 insertions(+)