Wireshark-commits: [Wireshark-commits] master-2.0 a745690: Lua: Free Pref default string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Dec 2015 19:30:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a745690f522b721b5733eab53e8677713f14ac7e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a745690 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Lua: Free Pref default string
    
    Store the Pref default string value and ensure this is freed both
    when registering the pref and when not.
    
    Use g_malloc0 to allocate Pref and avoid several init's.
    
    Change-Id: I5f97a15d06068d7805f02f7c7feea61f9b2030f5
    Reviewed-on: https://code.wireshark.org/review/12626
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 5625b62aa417c23102f254268563995773582e39)
    Reviewed-on: https://code.wireshark.org/review/12631
    

Actions performed:

    from  a8bd89e   No need to free the value of a string preference in the garbage collector.
    adds  a745690   Lua: Free Pref default string


Summary of changes:
 epan/wslua/wslua.h      |    1 +
 epan/wslua/wslua_pref.c |   12 +++++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)