Wireshark-commits: [Wireshark-commits] master-2.0 a8bd89e: No need to free the value of a string pr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Dec 2015 19:29:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8bd89e0b7c7f4be902c0625cdafadff2476a3a2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a8bd89e by Guy Harris (guy@xxxxxxxxxxxx):

    No need to free the value of a string preference in the garbage collector.
    
    The preference has already been deregistered at that point, so the value
    of the preference has been freed and the pointer to it has been set to
    null, so it's already been freed and its pointer no longer points to it
    and the free from Lua will do nothing.
    Change-Id: I11bf74932303151483cd3699659f67d64b466759
    Reviewed-on: https://code.wireshark.org/review/12606
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 3d0f9a4397125af15f40ab29e3fd1ad0ae2aae1a)
    Reviewed-on: https://code.wireshark.org/review/12630
    

Actions performed:

    from  08a43e3   [ppi] initialize phdr to 0
    adds  a8bd89e   No need to free the value of a string preference in the garbage collector.


Summary of changes:
 epan/wslua/wslua_pref.c |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)