Wireshark-commits: [Wireshark-commits] master 23379ae: NBAP : Verify conversation proto data exists
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Dec 2015 12:55:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23379ae3624df82c170f48e5bb3250a97ec61c13
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

23379ae by Anish Bhatt (anish@xxxxxxxxxxx):

    NBAP : Verify conversation proto data exists before trying to access it
    
    
    Bug 11841
    Change-Id: Ic0dea6491a68a042ddc0f2dbee19739e4568b18c
    Reviewed-on: https://code.wireshark.org/review/12576
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4e43fc4   capture_dlg (gtk): The use of 'if (A) {...} else if (A) {...}' pattern was detected found by PVS Studio (V517)
    adds  23379ae   NBAP : Verify conversation proto data exists before trying to access it


Summary of changes:
 asn1/nbap/nbap.cnf            |    9 ++++--
 epan/dissectors/packet-nbap.c |   69 +++++++++++++++++++++--------------------
 2 files changed, 42 insertions(+), 36 deletions(-)