Wireshark-commits: [Wireshark-commits] master 4e43fc4: capture_dlg (gtk): The use of 'if (A) {...}
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Dec 2015 12:54:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e43fc490a23086848011fd94b276949b9bfdf71
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4e43fc4 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    capture_dlg (gtk): The use of 'if (A) {...} else if (A) {...}' pattern was detected found by PVS Studio (V517)
    
    MIN_PACKET_SIZE is define on caputils/capture-pcap-util.h to 1
    
    Change-Id: Ib6486608cf3e0eac898ba859cf46e9d403d493d0
    Reviewed-on: https://code.wireshark.org/review/12364
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7762ee3   text_import: Argument with 'nonnull' attribute passed null found by Clang Analyzer
    adds  4e43fc4   capture_dlg (gtk): The use of 'if (A) {...} else if (A) {...}' pattern was detected found by PVS Studio (V517)


Summary of changes:
 ui/gtk/capture_dlg.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)