Wireshark · Wireshark-commits: [Wireshark-commits] master 76dd8a2: Start deprecating the capture info API.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76dd8a27b77aa959d4f6c6fb09c48b2e79d9cd47
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

76dd8a2 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Start deprecating the capture info API.
    
    The GTK+ UI has a capture info dialog which shows a summary of captured
    protocols, including IPX (!), NetBIOS (!!) and VINES (!!OMG!!). It's
    been disabled by default since 2006 (g59aa9e40).
    
    Remove the preference in the Qt UI capture pane. It's still available
    via the advanced prefs. Add comments in various parts of the code noting
    that the capture_info routines and structs are GTK+ only. Also note that
    if we *do* want to add a Qt capture info dialog we'll probably want to
    modernize the information we show.
    
    Change-Id: I3c63f6f01b60f0767fb33602a7f0c3b537dbde51
    Reviewed-on: https://code.wireshark.org/review/10991
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f06bbe3   Qt: validate format string before calling strftime()
    adds  76dd8a2   Start deprecating the capture info API.


Summary of changes:
 capture_info.h                      |    8 +++++++-
 capture_opts.h                      |    2 +-
 epan/packet.h                       |    5 +++++
 epan/prefs.c                        |    2 ++
 ui/preference_utils.c               |    2 +-
 ui/qt/capture_info_dialog.cpp       |    3 +++
 ui/qt/capture_preferences_frame.cpp |    8 --------
 ui/qt/capture_preferences_frame.h   |    2 --
 ui/qt/capture_preferences_frame.ui  |   11 +----------
 9 files changed, 20 insertions(+), 23 deletions(-)