Wireshark-commits: [Wireshark-commits] master-2.0 5e56fea: Qt: validate format string before callin
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e56fea8bfec4be7144ef0f3b5d5af578313c9ac
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
5e56fea by Pascal Quantin (pascal.quantin@xxxxxxxxx):
Qt: validate format string before calling strftime()
According to https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx
an invalid string will trigger invalid parameter handler
Also check the validity of each field before activating import button
Bug: 11873
Change-Id: I9fc1c6e061a02354690871410f0e2cf2e0dd86a7
Reviewed-on: https://code.wireshark.org/review/12537
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit f06bbe37c12c7788702cc8649e3da1f18c730931)
Reviewed-on: https://code.wireshark.org/review/12580
Actions performed:
from 265b394 Qt: Apply recent column widths when columns changed
adds 5e56fea Qt: validate format string before calling strftime()
Summary of changes:
ui/qt/import_text_dialog.cpp | 92 +++++++++++++++++++++++++++++++-----------
ui/qt/import_text_dialog.h | 15 ++++++-
ui/qt/import_text_dialog.ui | 2 +-
3 files changed, 83 insertions(+), 26 deletions(-)