Wireshark-commits: [Wireshark-commits] master 0a33e35: CIP: Ensure that all generated data is prope
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 9 Dec 2015 16:59:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a33e352f4116b850cded331482e3a9171cc6306
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0a33e35 by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Ensure that all generated data is properly flagged as Generated and no lengths are set for it.
    
    This ensures:
    1. Generated data shows inside brackets [], so it's obvious that the data was actually generated.
    2. Clicking on generated data should not highlight bytes in the packet. Previously, this would sometimes highlight parts of the response packet that were unrelated.
    3. Fixes some assertions that hit in PDML exporting code, due to wrong data locations being referenced.
    
    Bug: 11863
    Change-Id: Ia7ea9d886c8fff0c302088bed44b974ff9447a92
    Reviewed-on: https://code.wireshark.org/review/12468
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  afaf929   Qt: various fixes to VoIP calls / RTP player windows
    adds  0a33e35   CIP: Ensure that all generated data is properly flagged as Generated and no lengths are set for it.


Summary of changes:
 epan/dissectors/packet-cip.c |  170 +++++++++++++++++++++++++++---------------
 1 file changed, 110 insertions(+), 60 deletions(-)