Wireshark-commits: [Wireshark-commits] master-2.0 8ca1c8c: Qt: various fixes to VoIP calls / RTP pl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 9 Dec 2015 16:56:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ca1c8cfc0a1a8c1c632782fdec2772aaaa5da43
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

8ca1c8c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: various fixes to VoIP calls / RTP player windows
    
    - Flush any remaining tapped packets before emitting captureFileRetapFinished().
      This ensures that all packets have been treated before returning from retapPackets().
    - Remove VoIP tap listeners when captureFileRetapFinished() is emitted.
      This avoid summing stats each time the RTP player is opened, leading to wrong
      information in VoIP calls window
    - Change voip_calls_tapinfo_t redraw member from a boolean to bitmap so as to identify
      which tap should call the tapinfo->tap_draw() callback. This allows fixing a race condition
      where the RTP player can be empty in Qt UI
    - Reset some more statistics in voip_calls_reset_all_taps()
    
    Change-Id: Ie7681702c81d338185c1813f2d340a437edf3a04
    Reviewed-on: https://code.wireshark.org/review/12474
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit afaf929d0da03a27ef8824eac3c6b45b4419b062)
    Reviewed-on: https://code.wireshark.org/review/12487
    

Actions performed:

    from  9051613   Qt: store the absolute path names of recent files.
    adds  8ca1c8c   Qt: various fixes to VoIP calls / RTP player windows


Summary of changes:
 ui/gtk/voip_calls_dlg.c     |    7 +--
 ui/qt/capture_file.cpp      |    2 +
 ui/qt/capture_file.h        |    1 +
 ui/qt/main_window.cpp       |    2 +
 ui/qt/main_window.h         |    1 +
 ui/qt/main_window_slots.cpp |    5 ++
 ui/qt/voip_calls_dialog.cpp |   10 +++-
 ui/qt/voip_calls_dialog.h   |    1 +
 ui/qt/wireshark_dialog.h    |    2 +-
 ui/voip_calls.c             |  136 ++++++++++++++++++++++++++-----------------
 ui/voip_calls.h             |    4 +-
 11 files changed, 107 insertions(+), 64 deletions(-)