Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 5b10628: Split RTP player tapping, decoding, and plotting.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b106288cd7b3b1af3e74a7f1f22cb4bf876fbee
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5b10628 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Split RTP player tapping, decoding, and plotting.
    
    In RtpAudioStream split tapping+decoding into separate member functions.
    Store RTP payloads in memory. In RtpPlayerDialog split tapping+plotting.
    This more closely resembles what we're doing in the GTK+ UI and paves
    the way for jitter support and other changes.
    
    Change-Id: I244c225cec8930545622e6582b7be35ebe45b237
    Reviewed-on: https://code.wireshark.org/review/11195
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 8682eb49ef9e865be114ac57525628527bad1bd6)
    Reviewed-on: https://code.wireshark.org/review/11197
    

Actions performed:

    from  345034e   h261: fix "hf->bitmask != 0" assertion
    adds  5b10628   Split RTP player tapping, decoding, and plotting.


Summary of changes:
 epan/dissectors/packet-rtp.h |    4 +-
 ui/qt/rtp_audio_stream.cpp   |  242 +++++++++++++++++++++++-------------------
 ui/qt/rtp_audio_stream.h     |    7 +-
 ui/qt/rtp_player_dialog.cpp  |   27 +++--
 ui/qt/rtp_player_dialog.h    |    7 +-
 ui/qt/rtp_player_dialog.ui   |    2 +-
 ui/rtp_media.h               |    1 +
 ui/rtp_stream.h              |    2 +-
 8 files changed, 167 insertions(+), 125 deletions(-)