Wireshark-commits: [Wireshark-commits] master 8682eb4: Split RTP player tapping, decoding, and plot
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Oct 2015 17:52:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8682eb49ef9e865be114ac57525628527bad1bd6
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8682eb4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Split RTP player tapping, decoding, and plotting.
    
    In RtpAudioStream split tapping+decoding into separate member functions.
    Store RTP payloads in memory. In RtpPlayerDialog split tapping+plotting.
    This more closely resembles what we're doing in the GTK+ UI and paves
    the way for jitter support and other changes.
    
    Change-Id: I244c225cec8930545622e6582b7be35ebe45b237
    Reviewed-on: https://code.wireshark.org/review/11195
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ed27dad   h261: fix "hf->bitmask != 0" assertion
    adds  8682eb4   Split RTP player tapping, decoding, and plotting.


Summary of changes:
 epan/dissectors/packet-rtp.h |    4 +-
 ui/qt/rtp_audio_stream.cpp   |  242 +++++++++++++++++++++++-------------------
 ui/qt/rtp_audio_stream.h     |    7 +-
 ui/qt/rtp_player_dialog.cpp  |   27 +++--
 ui/qt/rtp_player_dialog.h    |    7 +-
 ui/qt/rtp_player_dialog.ui   |    2 +-
 ui/rtp_media.h               |    1 +
 ui/rtp_stream.h              |    2 +-
 8 files changed, 167 insertions(+), 125 deletions(-)