Wireshark-commits: [Wireshark-commits] master 3f56b5e: Qt: fix crash when double clicking on a row
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Oct 2015 18:16:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f56b5e6b91ec2d57c8ce48606332368c17665dd
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3f56b5e by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix crash when double clicking on a row in 'Decode As' dialog
    
    No need to register for the destroyed() signal: it is emitted after the new
    QComboBox object is created and resetting pointers to NULL is useless as they
    are locals initialized in the constructor
    
    Bug: 11532
    Change-Id: Ie707cafa370053df846a4732aed20c182e030c40
    Reviewed-on: https://code.wireshark.org/review/10792
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a459ac7   Add BASE_PT_ field display types
    adds  3f56b5e   Qt: fix crash when double clicking on a row in 'Decode As' dialog


Summary of changes:
 ui/qt/decode_as_dialog.cpp |   21 ++-------------------
 ui/qt/decode_as_dialog.h   |    3 ---
 2 files changed, 2 insertions(+), 22 deletions(-)