Wireshark-commits: [Wireshark-commits] master a459ac7: Add BASE_PT_ field display types
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Oct 2015 18:10:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a459ac72a2c01ec12d186907837aff891e3e223b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a459ac7 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Add BASE_PT_ field display types
    
    Avoid displaying duplicate port numbers with transport name resolution disabled and
    make some dissector code simpler.
    
    Introduces port_with_resolution_to_str_buf() function and amends UDP/TCP/DCCP/SCTP to
    use the new field display type.
    
    Change-Id: Ifb97810b9c669ccbb1a310a2c0ffd6e2b63af210
    Reviewed-on: https://code.wireshark.org/review/10625
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d52322e   SCTP I-DATA support
    adds  a459ac7   Add BASE_PT_ field display types


Summary of changes:
 doc/README.dissector          |    9 +++++++
 epan/addr_resolv.c            |   23 +++++++++++-----
 epan/addr_resolv.h            |    9 ++++++-
 epan/dissectors/packet-dccp.c |   59 ++++++++++++++++++-----------------------
 epan/dissectors/packet-sctp.c |    8 +++---
 epan/dissectors/packet-tcp.c  |   40 +++++-----------------------
 epan/dissectors/packet-udp.c  |   40 ++++++----------------------
 epan/proto.c                  |   51 ++++++++++++++++++++++++++++++++++-
 epan/proto.h                  |   33 ++++++++++++++---------
 9 files changed, 149 insertions(+), 123 deletions(-)