Wireshark-commits: [Wireshark-commits] master 57d954e: Treat IPv4 subnet masks as distinct from add
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 Oct 2015 20:49:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57d954e1689ab31c6afac0a787f13754b8a39a49
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

57d954e by Jeffrey Smith (whydoubt@xxxxxxxxx):

    Treat IPv4 subnet masks as distinct from addresses
    
    While IPv4 subnet masks are obviously related and similar to IPv4
    addresses, they are distinct enough that they need to be treated
    seperately in some aspects.  For instance, there is no value in
    attempting to resolve a subnet mask.
    
    This change creates a new display type: BASE_NETMASK, which allows distinction from FT_IPv4
    (and possible name resolution) where appropriate.
    
    Change-Id: I99e19c9a58eb613f8e58d481af84c30e2e5e14d7
    Reviewed-on: https://code.wireshark.org/review/10438
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b02a0ee   Fix crashes related to RTP Streams analysis
    adds  57d954e   Treat IPv4 subnet masks as distinct from addresses


Summary of changes:
 doc/README.dissector                  |    7 +++++++
 epan/dfilter/scanner.l                |    2 +-
 epan/dissectors/packet-adwin-config.c |    2 +-
 epan/dissectors/packet-afs.c          |    2 +-
 epan/dissectors/packet-bootp.c        |    4 ++--
 epan/dissectors/packet-capwap.c       |    4 ++--
 epan/dissectors/packet-chdlc.c        |    2 +-
 epan/dissectors/packet-dvmrp.c        |    2 +-
 epan/dissectors/packet-enip.c         |    2 +-
 epan/dissectors/packet-epl.c          |    2 +-
 epan/dissectors/packet-gvcp.c         |    6 +++---
 epan/dissectors/packet-isakmp.c       |    4 ++--
 epan/dissectors/packet-olsr.c         |    2 +-
 epan/dissectors/packet-opsi.c         |    2 +-
 epan/dissectors/packet-ospf.c         |    8 ++++----
 epan/dissectors/packet-rip.c          |    2 +-
 epan/dissectors/packet-rsip.c         |    2 +-
 epan/dissectors/packet-smcr.c         |    2 +-
 epan/dissectors/packet-wassp.c        |    4 ++--
 epan/proto.c                          |   25 ++++++++++++++++++++++++-
 epan/proto.h                          |    6 +++++-
 21 files changed, 63 insertions(+), 29 deletions(-)