Wireshark-commits: [Wireshark-commits] master b02a0ee: Fix crashes related to RTP Streams analysis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 Oct 2015 20:47:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b02a0ee48a51ccbb33ad76ce84ecb05409a6973a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b02a0ee by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix crashes related to RTP Streams analysis
    
    The data that describes RTP streams become invalid when packets are
    re-dissected. This results in a crash in GTK when the "RTP Analyse"
    option is used and and a crash in Qt when the display filter is changed
    while the RTP Streams dialog is open.
    
    Fix this by adding a tap_reset callback (modelled after mcaststream) to
    the RTP tap listener that allows the GTK+ and Qt dialogs to clear the
    displayed list of RTP streams.
    
    Bug: 10016
    Change-Id: I7478678db63d7ac8110c44c163844e9f66fad9e9
    Reviewed-on: https://code.wireshark.org/review/10728
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ba5df1e   Revert "gtk: Fix crash on Analyze RTP stream"
    adds  b02a0ee   Fix crashes related to RTP Streams analysis


Summary of changes:
 ui/cli/tap-rtp.c            |    2 +-
 ui/gtk/rtp_stream_dlg.c     |   14 ++++++++++++--
 ui/qt/rtp_stream_dialog.cpp |   10 ++++++++++
 ui/qt/rtp_stream_dialog.h   |    1 +
 ui/rtp_stream.h             |    2 ++
 ui/tap-rtp-common.c         |    7 ++++++-
 6 files changed, 32 insertions(+), 4 deletions(-)