Wireshark · Wireshark-commits: [Wireshark-commits] master 3b04a89: ncp2222: Use BASE_CUSTOM for date and time fields.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b04a89828a12ee71aa6693aadb900862c9d3c75
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b04a89 by Michael Mann (mmann78@xxxxxxxxxxxx):

    ncp2222: Use BASE_CUSTOM for date and time fields.
    
    This simplifies some of the logic required for field formatting.
    
    Change-Id: I2f9a612b18e3e4ca01311683d9cf61cbad9950f4
    Reviewed-on: https://code.wireshark.org/review/10649
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a4a453b   Convert dissect_nds_request and dissect_nds_reply to use proto_tree_add_xxx directly instead of the homegrown nds_val.
    adds  3b04a89   ncp2222: Use BASE_CUSTOM for date and time fields.


Summary of changes:
 epan/dissectors/packet-ncp-int.h   |    6 --
 epan/dissectors/packet-ncp2222.inc |  199 +++++-------------------------------
 tools/ncp2222.py                   |   33 +++---
 3 files changed, 40 insertions(+), 198 deletions(-)