Wireshark-commits: [Wireshark-commits] master a4a453b: Convert dissect_nds_request and dissect_nds_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Sep 2015 20:20:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4a453b13db2c8d28d6999f6c1c03141f0eaf1da
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a4a453b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Convert dissect_nds_request and dissect_nds_reply to use proto_tree_add_xxx directly instead of the homegrown nds_val.
    
    Change-Id: Ie67892caec2cddee591631045233f8a3f1cc0bc6
    Reviewed-on: https://code.wireshark.org/review/10648
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ff1dbba   CMake: Add a hardening-check target.
    adds  a4a453b   Convert dissect_nds_request and dissect_nds_reply to use proto_tree_add_xxx directly instead of the homegrown nds_val.


Summary of changes:
 epan/dissectors/packet-ncp2222.inc | 4601 +++++++++++-------------------------
 tools/ncp2222.py                   |   37 +-
 2 files changed, 1399 insertions(+), 3239 deletions(-)