Wireshark · Wireshark-commits: [Wireshark-commits] master 38b6f30: Refactor NCP Python data so that INFO column can be generated on

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38b6f306a70905be8b29ffaeb75288d315ff9b04
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

38b6f30 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor NCP Python data so that INFO column can be generated on the fly.
    
    The "old" method of populating the INFO column was to dissect all fields of a function/subfunction, then do a search in the tree to find the hf_ values of interest to then format into something for the INFO column.  This is very expensive and requires "low level" APIs (for tree manipulation) which really shouldn't be used in a dissector.
    
    The "new" method populates the INFO column at the same time a field is parsed, so nothing has to be revisited.
    
    There are still expert infos (and possibly column APIs) under if (tree)s, but with the FAKE_TREE_IS_VISIBLE "hacks" removed, there should be less fear in removing the tree checks.
    
    Change-Id: I847827395fc28704f468df8bc8b47b297dde8479
    Reviewed-on: https://code.wireshark.org/review/10572
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2758114   Some more ncp2222 improvements
    adds  38b6f30   Refactor NCP Python data so that INFO column can be generated on the fly.


Summary of changes:
 epan/dissectors/packet-ncp-int.h   |   15 +-
 epan/dissectors/packet-ncp2222.inc |  607 +++++++----------------
 tools/ncp2222.py                   |  926 ++++++++++++++++++------------------
 3 files changed, 661 insertions(+), 887 deletions(-)