Wireshark-commits: [Wireshark-commits] master 2758114: Some more ncp2222 improvements
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Sep 2015 08:13:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2758114e0af437b51727f12a497e30347bb2cf9a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2758114 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Some more ncp2222 improvements
    
    Including:
    1. Using ENC_BIG_ENDIAN and ENC_LITTLE_ENDIAN instead of self made macros
    
    2. Creating an "expert info hook" so that fields can be parsed "in real time" and added as expert info instead of searching by field name and manually getting values.  Most of the expert info is still under if (tree)s, but this is another step closer to removing all of the "manual labor" done that requires "special handling" of all tree functionality.  Once the "manual labor" is removed, this dissector can behave like every other dissector and the if (tree)s can be removed with more abandon.
    
    Change-Id: If2c6a4c723e12e070e68d6df2d492d4b5ac35123
    Reviewed-on: https://code.wireshark.org/review/10555
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7b7a7f1   Fix a VoipCallsDialog signal+slot mismatch.
    adds  2758114   Some more ncp2222 improvements


Summary of changes:
 epan/dissectors/packet-ncp-int.h   |    9 +-
 epan/dissectors/packet-ncp2222.inc |  687 ++++++++++------------
 tools/ncp2222.py                   | 1112 ++++++++++++++++++------------------
 3 files changed, 884 insertions(+), 924 deletions(-)