Wireshark · Wireshark-commits: [Wireshark-commits] master 1565157: Bootp/DHCP: Add option 242 (Avaya IP Telephone)

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=156515732a6d8b01e9926bff000021729f3b1ced
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1565157 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    Bootp/DHCP: Add option 242 (Avaya IP Telephone)
    
    This commit adds handling for option 242 to bootp.
    The value of the Avaya option 242 is a string containing a list of
    several suboptions seperated by a ",".
    However some suboptions may have multiple values also seperated by
    a comma. The values may be enclosed in quotes.
    
    A real-life string e.g. looks like:
    MCIPADD=10.1.1.2,10.1.1.3,TLSSRVR=10.1.1.5,VLANTEST=60,L2Q=1,L2QVLAN=77
    
    Documentation can be found here:
    https://downloads.avaya.com/elmodocs2/one-X_Deskphone_Edition/R1.5/output/16_300698_4/admn054.html and
    http://downloads.avaya.com/css/P8/documents/100068659
    
    A set of crafted packets is attached to the bug.
    
    Bug: 11021
    Change-Id: I99b557a952fd34c0fcab6d0a5311440969316973
    Reviewed-on: https://code.wireshark.org/review/7443
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  33570f8   Fix misaligned read and buffer overrun
    adds  1565157   Bootp/DHCP: Add option 242 (Avaya IP Telephone)


Summary of changes:
 epan/dissectors/packet-bootp.c |  315 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 314 insertions(+), 1 deletion(-)