Wireshark-commits: [Wireshark-commits] master 33570f8: Fix misaligned read and buffer overrun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Sep 2015 02:38:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33570f81b55b3ac846e2b16836b5a0b3083de1b3
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

33570f8 by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix misaligned read and buffer overrun
    
    Ethernet addresses are only 6 bytes in size, reading it as a 64-bit
    integer is invalid. Use unsigned 8-bit integers instead.
    
    Caught by UBSAN and Address Sanitizer. Trigger via the Statistics menu
    Resolved Addresses (Qt) or Show address resolution (GTK).
    
    Change-Id: I628ff7cce0ea4f4e378c7968cd79a0ae34cdd20b
    Reviewed-on: https://code.wireshark.org/review/10443
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  648cf99   Make other_decode_bitfield_value private to proto.c.
    adds  33570f8   Fix misaligned read and buffer overrun


Summary of changes:
 ui/gtk/addr_resolution_dlg.c        |   20 ++++++--------------
 ui/qt/resolved_addresses_dialog.cpp |   14 +++++++-------
 2 files changed, 13 insertions(+), 21 deletions(-)