Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 33bc8d8: Block sizes are unsigned 32-bit quantities; don't stuff the

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33bc8d80c736b7596ed5d59d115dac53f3b3e3b8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

33bc8d8 by Guy Harris (guy@xxxxxxxxxxxx):

    Block sizes are unsigned 32-bit quantities; don't stuff them into an int.
    
    *Especially* don't stuff the amount of remaining data in a block into an
    int that will then be passed to file_skip() as an amount to skip ahead,
    as a Really Large Value will turn into a negative value and produce
    various forms of bizarre and tricky-to-debug behavior.
    
    Change-Id: I5ca32cdc35564d4fe34eac944dedc10b56a5d407
    Reviewed-on: https://code.wireshark.org/review/10300
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8d0c841   Have separate variables for read and write errors.
    adds  33bc8d8   Block sizes are unsigned 32-bit quantities; don't stuff them into an int.


Summary of changes:
 wiretap/pcapng.c        |    2 +-
 wiretap/pcapng_module.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)