Wireshark · Wireshark-commits: [Wireshark-commits] master 1663224: Block sizes are unsigned 32-bit quantities; don't stuff them int

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1663224c24b38dac3218c8690d1035f5b63a548f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1663224 by Guy Harris (guy@xxxxxxxxxxxx):

    Block sizes are unsigned 32-bit quantities; don't stuff them into an int.
    
    *Especially* don't stuff the amount of remaining data in a block into an
    int that will then be passed to file_skip() as an amount to skip ahead,
    as a Really Large Value will turn into a negative value and produce
    various forms of bizarre and tricky-to-debug behavior.
    
    Change-Id: I4d0a6b36fe50df84925690ad688a3ab0433ceb17
    Reviewed-on: https://code.wireshark.org/review/10299
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  15c9923   Qt: Fix use-after-free pattern
    adds  1663224   Block sizes are unsigned 32-bit quantities; don't stuff them into an int.


Summary of changes:
 wiretap/pcapng.c        |    2 +-
 wiretap/pcapng_module.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)