Wireshark-commits: [Wireshark-commits] master 7176958: Close packet dialogs when reload Lua plugins
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Aug 2015 07:43:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7176958357cc1e993931463e40814d37083de260
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7176958 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Close packet dialogs when reload Lua plugins.
    
    We could keep the dialogs with the current content if postponing
    proto_free_deregistered_fields() until all dialogs are closed.
    This would give a feature where the user is able to compare packets
    before and after a reload.
    
    Or we could add functions in PacketDialog to reload the packet details
    in all open dialogs.  This would give a feature to always have a
    updated dialog for all interesting packets.
    
    Change-Id: I805352b65844eafafafc54cd61f08b4605416e64
    Reviewed-on: https://code.wireshark.org/review/10201
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  25ec198   Disable streamNumberSpinBox while reloading capture
    adds  7176958   Close packet dialogs when reload Lua plugins.


Summary of changes:
 ui/qt/main_window.h         |    3 +++
 ui/qt/main_window_slots.cpp |   17 +++++++++++++++++
 ui/qt/packet_dialog.cpp     |   12 ++++++++++++
 ui/qt/packet_dialog.h       |    4 ++++
 4 files changed, 36 insertions(+)