Wireshark-commits: [Wireshark-commits] master 25ec198: Disable streamNumberSpinBox while reloading
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Aug 2015 07:43:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=25ec198dd4dd9f8cfcef56548501391d49b9fa40
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

25ec198 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Disable streamNumberSpinBox while reloading capture
    
    When changing stream in TCPStreamDialog it should not be possible
    to change stream again until the capture has reloaded, because
    this will give a crash when doing graph_segment_list_free() or
    graph_segment_list_get() while already doing this.
    
    Also disable mouseMove event (showing packet details) while reloading,
    as this also will give a crash.
    
    We should consider also having a reload progress bar in the
    TCPStreamDialog to indicate that this is happening when having
    large capture files, as the main window may not be visible.
    
    Change-Id: I622f9e0de8205bc1fd18101dc03100079d7a2d06
    Reviewed-on: https://code.wireshark.org/review/10159
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  47c9aa4   Check if IPv6 payload length exceeds framing byte length
    adds  25ec198   Disable streamNumberSpinBox while reloading capture


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp |    6 ++++++
 1 file changed, 6 insertions(+)