Wireshark · Wireshark-commits: [Wireshark-commits] master f73e1c2: Allow redefining all ports for RADIUS

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f73e1c29562fc64e01be01570f1673783f79537b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f73e1c2 by Peter Lemenkov (lemenkov@xxxxxxxxx):

    Allow redefining all ports for RADIUS
    
    RADIUS configuration sometimes uses more ports - for example, one for
    authentication, another one for accounting. Sometimes it uses the entire
    port ranges. In case of FreeRADIUS 2.x.x server it might look like this:
    
    ...
    listen {
            type = auth
            ipaddr = *
            port = 13812
    }
    listen {
            type = acct
            ipaddr = *
            port = 13813
    }
    ...
    
    Unfortunately we allow only one port to be redefined, not more. So it
    forces a person who's analyzing a traffic from such a RADIUS server
    manually select "Decode as" every time for each port.
    
    It was requested at least once to lift this limitation:
    
    * https://ask.wireshark.org/questions/2189/decode-multiple-ports-as-radius
    
    So let's fix it!
    
    With this commit it's possible to set a port ranges for RADIUS dissector
    to handle. An example (default) configuration looks like (see
    ~/.wireshark/preferences):
    
    radius.ports: 1645,1646,1700,1812,1813,3799
    
    Old "alternate_port" preference is marked as obsolete. It won't be shown
    to a user but it will still be used if exists (remained from a previous
    installations).
    
    *Ver. 2*:
    Old alternate_port value is copied to the ports range, thus making
    transition even more smooth.
    
    Change-Id: Ibdd6f4f9fa1e0ac186147cec380bbfc62d509b17
    Signed-off-by: Peter Lemenkov <lemenkov@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/10015
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7d59925   SSL: refine KEX handling and fix _anon KEX dissecting
    adds  f73e1c2   Allow redefining all ports for RADIUS


Summary of changes:
 epan/dissectors/packet-radius.c |   60 ++++++++++++++++++++++++++-------------
 1 file changed, 41 insertions(+), 19 deletions(-)