Wireshark-commits: [Wireshark-commits] master 7d59925: SSL: refine KEX handling and fix _anon KEX d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Aug 2015 08:57:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d599251f6dc063e1ad84ee76977c2af0b0ac4fb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7d59925 by Timo Warns (timow+github@xxxxxxxxxxxxxxxxxxxx):

    SSL: refine KEX handling and fix _anon KEX dissecting
    
    Dissecting client and server KEX messages requires to precisely distinguish KEX
    algos. For example, Server KEX for DH_anon do not contain a signature, while
    DHE_DSS and DHE_RSA do. The patch introduces KEX distinction with full
    precision and fixes dissecting _anon KEX messages.
    
    Change-Id: I0bcd5e2bf899ba9cac79476d5b7a1ffb3accf0db
    Reviewed-on: https://code.wireshark.org/review/9836
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8d5ac86   Try to fix: wlan_statistics_dialog.cpp:466:1: error: unused parameter ‘filter’ [-Werror=unused-parameter]
    adds  7d59925   SSL: refine KEX handling and fix _anon KEX dissecting


Summary of changes:
 epan/dissectors/packet-ssl-utils.c | 1017 +++++++++++++++++++++---------------
 epan/dissectors/packet-ssl-utils.h |   24 +-
 2 files changed, 604 insertions(+), 437 deletions(-)