Wireshark-commits: [Wireshark-commits] master 85f8a99: ssl-utils: fix failing decryption for some R
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jul 2015 21:31:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=85f8a99f354850d5fbf774b04e9721195614d7d8
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

85f8a99 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: fix failing decryption for some RSA keys
    
    Reported at
    https://ask.wireshark.org/questions/43788/struggling-to-decrypt-ssl
    
    "u" requirement is documented at
    https://www.gnupg.org/documentation/manuals/gcrypt/RSA-key-parameters.html#RSA-key-parameters
    
    Add regression test (key is generated manually with p and q swapped and
    qInv recalculated).
    
    Change-Id: I5505ddcdb54bb47d7a58867b8c3e53fcc0f66dde
    Reviewed-on: https://code.wireshark.org/review/9573
    Tested-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  79be831   ssl-utils: remove unused, broken libgcrypt code
    adds  85f8a99   ssl-utils: fix failing decryption for some RSA keys


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    5 +++++
 test/captures/rsa-p-lt-q.pcap      |  Bin 0 -> 2111 bytes
 test/keys/rsa-p-lt-q.key           |   15 +++++++++++++++
 test/suite-decryption.sh           |   16 ++++++++++++++++
 4 files changed, 36 insertions(+)
 create mode 100644 test/captures/rsa-p-lt-q.pcap
 create mode 100644 test/keys/rsa-p-lt-q.key