Wireshark · Wireshark-commits: [Wireshark-commits] master 79be831: ssl-utils: remove unused, broken libgcrypt code

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79be8312da5f572664e8a56d6e98d92dc34fdc95
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

79be831 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: remove unused, broken libgcrypt code
    
    Remove unused SSL_FAST code. That approach cannot work in modern
    libgcrypt anyway since the symbols were renamed and private to
    libgcrypt. The RSA decryption routine is not even a hot path, it is only
    called for decrypting the encrypted pre-master secret.
    
    While at it, expand the SSL_PRIVATE_KEY macro and remove its definition.
    
    Change-Id: Ied556d18501ea6cbac5fb27218364b3479ad62ce
    Reviewed-on: https://code.wireshark.org/review/9572
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  c8c8eef   zvt: handle multi-byte tags
    adds  79be831   ssl-utils: remove unused, broken libgcrypt code


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   38 ++++--------------------------------
 epan/dissectors/packet-ssl-utils.h |   17 ++++++++--------
 2 files changed, 12 insertions(+), 43 deletions(-)