Wireshark-commits: [Wireshark-commits] master ba9aa30: Split more init routines into init/cleanup f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 23:37:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba9aa3015f29f07bf81cdfebdfab54fdc379b94d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba9aa30 by Peter Wu (peter@xxxxxxxxxxxxx):

    Split more init routines into init/cleanup functions
    
    This patch is partially automatically generated, but are modified
    manually. In particular, assignments and function calls have been
    audited.
    
    Some debugging comments and ifdef'd prints have been removed. The
    lookup tables of the dcm and sip dissectors are now cleared. It is only
    called on reopening files anyway.
    
    The isakmp dissector is modified to use g_hash_table_new_full for
    destruction of its keys and values.
    
    Fix a memleak in ipsec dissector when libgcrypt is not enabled.
    
    Generated using
    https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=3c6128ee266024d164650955f93c7740484abd68
    (with AUDIT = True).
    
    Change-Id: I3fd910bdee663842ac0196334fe0189b67e251b0
    Reviewed-on: https://code.wireshark.org/review/9225
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ea46cf4   Split init of misc dissectors into init/cleanup functions
    adds  ba9aa30   Split more init routines into init/cleanup functions


Summary of changes:
 epan/dissectors/packet-6lowpan.c    |    8 +++++
 epan/dissectors/packet-beep.c       |   14 ++++----
 epan/dissectors/packet-dcerpc.c     |   28 ++++++---------
 epan/dissectors/packet-dcm.c        |   42 ++++++++++++-----------
 epan/dissectors/packet-epl.c        |    7 ++++
 epan/dissectors/packet-ieee802154.c |   17 +++++-----
 epan/dissectors/packet-ipsec.c      |   27 ++++++---------
 epan/dissectors/packet-isakmp.c     |   41 ++++++++++++----------
 epan/dissectors/packet-mac-lte.c    |   64 ++++++++++-------------------------
 epan/dissectors/packet-opensafety.c |   11 ++++--
 epan/dissectors/packet-sigcomp.c    |   22 ++++--------
 epan/dissectors/packet-sip.c        |   33 ++++++++----------
 epan/dissectors/packet-umts_mac.c   |   14 ++++----
 13 files changed, 152 insertions(+), 176 deletions(-)