Wireshark-commits: [Wireshark-commits] master ea46cf4: Split init of misc dissectors into init/clea
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 23:37:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea46cf4f73c72bf343a5d07ba33166d696a3d1f6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea46cf4 by Peter Wu (peter@xxxxxxxxxxxxx):

    Split init of misc dissectors into init/cleanup functions
    
    Convert remaining dissectors to use cleanup routines when possible.
    (Single-)linked lists require NULL, so do reset their pointers to NULL.
    
    Generated with
    https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=69af86e6c2cf965ba3d7f9636b647b195f0b7d57
    (with AUDIT = ALWAYS_EMIT_CLEANUP_CODE = True)
    
    Remaining dissectors which did not need further changes:
    epan/dissectors/packet-aeron.c
    epan/dissectors/packet-bootp.c
    epan/dissectors/packet-brdwlk.c
    epan/dissectors/packet-drda.c
    epan/dissectors/packet-etch.c
    epan/dissectors/packet-fix.c
    epan/dissectors/packet-fw1.c
    epan/dissectors/packet-lbm.c
    epan/dissectors/packet-ldss.c
    epan/dissectors/packet-simulcrypt.c
    epan/dissectors/packet-spdy.c
    epan/dissectors/packet-starteam.c
    epan/dissectors/packet-udp.c
    
    Change-Id: Idcacfea6a5de38d40e67db4cdcd0452ad9f9a6a9
    Reviewed-on: https://code.wireshark.org/review/9228
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7ce77c6   Split four more init routines into init/cleanup
    adds  ea46cf4   Split init of misc dissectors into init/cleanup functions


Summary of changes:
 epan/dissectors/packet-dcom.c        |    7 ++-----
 epan/dissectors/packet-gtp.c         |    4 ++--
 epan/dissectors/packet-h223.c        |   17 ++++++++---------
 epan/dissectors/packet-iax2.c        |   32 ++++++++++++++++----------------
 epan/dissectors/packet-l2tp.c        |    4 ++--
 epan/dissectors/packet-ntlmssp.c     |   18 ++++++++----------
 epan/dissectors/packet-sctp.c        |   32 ++++++++------------------------
 epan/dissectors/packet-smb.c         |    9 ++-------
 epan/dissectors/packet-umts_fp.c     |    1 -
 epan/dissectors/packet-x11.c         |    4 ++--
 epan/dissectors/packet-zbee-nwk-gp.c |   14 ++++++++++----
 11 files changed, 60 insertions(+), 82 deletions(-)