Wireshark-commits: [Wireshark-commits] master-1.12 51f7a9a: p1: Fixed do_address for extension attr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 May 2015 16:54:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51f7a9aef3b4d6b33e84a6042b305baf4e3fa90d
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

51f7a9a by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    p1: Fixed do_address for extension attributes
    
    This is not an optimal solution, but fixes the reported problem.
    The do_address functionality should probably be rewritten to
    only use pinfo for storing data.
    
    Bug: 11210
    Ping-Bug: 8515
    
    Change-Id: Iad41e28b9d71f2cb9d8804998332c11fa57cb49d
    Reviewed-on: https://code.wireshark.org/review/8591
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  eb93c66   Include <sys/param.h> to get MAXPATHLEN.
    adds  51f7a9a   p1: Fixed do_address for extension attributes


Summary of changes:
 asn1/p1/p1.cnf               |    5 ++
 asn1/p1/packet-p1-template.c |   23 +++++-
 epan/dissectors/packet-p1.c  |  180 ++++++++++++++++++++++++------------------
 3 files changed, 126 insertions(+), 82 deletions(-)