Wireshark-commits: [Wireshark-commits] master a34d696: p1: Fixed do_address for extension attribute
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 May 2015 16:11:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a34d696377afc2b4eaee5710c385292da613510c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a34d696 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    p1: Fixed do_address for extension attributes
    
    This is not an optimal solution, but fixes the reported problem.
    The do_address functionality should probably be rewritten to
    only use pinfo for storing data.
    
    Bug: 11210
    Ping-Bug: 8515
    Change-Id: I2625cc4044ab93b6e943a3c2d2ffd1b26149da29
    Reviewed-on: https://code.wireshark.org/review/8585
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3bc42db   Netscaler: Add support to read MTCP record.
    adds  a34d696   p1: Fixed do_address for extension attributes


Summary of changes:
 asn1/p1/p1.cnf               |    5 ++
 asn1/p1/packet-p1-template.c |   24 +++++-
 epan/dissectors/packet-p1.c  |  183 +++++++++++++++++++++++-------------------
 3 files changed, 127 insertions(+), 85 deletions(-)