Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 e6b8eec: Fix filtering on IP heuristic subdissectors.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e6b8eece696fa370a6be9055b29e0f969dbe3162
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e6b8eec by Jesse Gross (jesse@xxxxxxxxxx):

    Fix filtering on IP heuristic subdissectors.
    
    The IP dissector passes 'tree' to its heuristic dissectors instead
    of the 'parent_tree' passed to the normally registered dissectors.
    These two are generally the same except that 'tree' is set to NULL
    in cases where IP is not referenced - a local optimization that
    should not be passed down to the lower layers. The result is that
    the filter:
    ip && PROTO matches
    but:
    PROTO does not match.
    
    This changes the two types of dissectors to behave the same by
    getting 'parent_tree'.
    
    Change-Id: I78690d4767d2e3a763fd4388792c49aa5df0a962
    Reviewed-on: https://code.wireshark.org/review/8190
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit fa16e70902eae661b3fc7703943b6d2195ac0cd8)
    Reviewed-on: https://code.wireshark.org/review/8191
    

Actions performed:

    from  a4572ba   LPP: fix a typo in the protocol abbreviation
    adds  e6b8eec   Fix filtering on IP heuristic subdissectors.


Summary of changes:
 epan/dissectors/packet-ip.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)