Wireshark-commits: [Wireshark-commits] master fa16e70: Fix filtering on IP heuristic subdissectors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Apr 2015 03:08:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa16e70902eae661b3fc7703943b6d2195ac0cd8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fa16e70 by Jesse Gross (jesse@xxxxxxxxxx):

    Fix filtering on IP heuristic subdissectors.
    
    The IP dissector passes 'tree' to its heuristic dissectors instead
    of the 'parent_tree' passed to the normally registered dissectors.
    These two are generally the same except that 'tree' is set to NULL
    in cases where IP is not referenced - a local optimization that
    should not be passed down to the lower layers. The result is that
    the filter:
    ip && PROTO matches
    but:
    PROTO does not match.
    
    This changes the two types of dissectors to behave the same by
    getting 'parent_tree'.
    
    Change-Id: I78690d4767d2e3a763fd4388792c49aa5df0a962
    Reviewed-on: https://code.wireshark.org/review/8190
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ad36856   add register_dissector call for name batadv
    adds  fa16e70   Fix filtering on IP heuristic subdissectors.


Summary of changes:
 epan/dissectors/packet-ip.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)